Create yarn build workflow #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpagnoux
approved these changes
May 19, 2022
|
Thanks; I'll wait to merge this until the build is actually working (the linked PR) methinks. |
|
I'll open a side-PR to handle these warnings |
|
Oh ok cool. If you're ok with this being broken, then do you want to
merge-override this one?
…On Thu, May 19, 2022, 17:22 Florian Pagnoux ***@***.***> wrote:
#29 <#29>
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AAGKPQZXI5EANVJI2DAULBLVK2WHTANCNFSM5WKMLCQQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Oh, nope, got it; merge that one first then this one. Approved #29.
On Thu, May 19, 2022, 17:26 Michele Pratusevich <
***@***.***> wrote:
… Oh ok cool. If you're ok with this being broken, then do you want to
merge-override this one?
On Thu, May 19, 2022, 17:22 Florian Pagnoux ***@***.***>
wrote:
> #29 <#29>
>
> —
> Reply to this email directly, view it on GitHub
> <#28 (comment)>,
> or unsubscribe
> <https:/notifications/unsubscribe-auth/AAGKPQZXI5EANVJI2DAULBLVK2WHTANCNFSM5WKMLCQQ>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
|
|
Thanks! Just merged 29, so if you merge |
|
@fpagnoux See my comment about bootstrap (in #30); we have to run the beta of that to fix a downstream dependency issue with a different node package. Nothing seemed off to me in my local dev environment, but if you want to take a look before I finally merge this go for it. Regardless, CI now passes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Github Actions workflow to always install and build with yarn to ensure no issues in production.
Note: the current version of
mainis not buildable - this CI will pass once #27 is merged.One additional change (pinning
autoprefixer) had to be done to remove one additional CI warning per twbs/bootstrap#36259. Had to upgrade to the 5.2.0-beta release of bootstrap to get this to pass CI. Issue created to track moving away from beta: #30